Bug 212840 - [JSC] Put dfgOpNames in __DATA,__const section instead of __DATA,__data
Summary: [JSC] Put dfgOpNames in __DATA,__const section instead of __DATA,__data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-05 12:09 PDT by Yusuke Suzuki
Modified: 2020-06-05 19:00 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2020-06-05 12:11 PDT, Yusuke Suzuki 		saam: review+
Details | Formatted Diff | Diff
Patch for landing (4.83 KB, patch)
2020-06-05 12:48 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch for landing (4.98 KB, patch)
2020-06-05 14:23 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch for landing (5.01 KB, patch)
2020-06-05 14:27 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-06-05 12:09:05 PDT 
[JSC] Put dfgOpNames in __DATA,__const section instead of __DATA,__data
Comment 1 Yusuke Suzuki 2020-06-05 12:11:23 PDT 
Created attachment 401180 [details]
Patch
Comment 2 Mark Lam 2020-06-05 12:15:25 PDT 
Comment on attachment 401180 [details]
Patch

Nice. r=me too.
Comment 3 Yusuke Suzuki 2020-06-05 12:18:44 PDT 
Oops, compile failures. Fixing.
Comment 4 Yusuke Suzuki 2020-06-05 12:48:22 PDT 
Created attachment 401187 [details]
Patch for landing
Comment 5 Yusuke Suzuki 2020-06-05 14:23:53 PDT 
Created attachment 401196 [details]
Patch for landing
Comment 6 Yusuke Suzuki 2020-06-05 14:27:25 PDT 
Created attachment 401199 [details]
Patch for landing
Comment 7 Yusuke Suzuki 2020-06-05 18:43:50 PDT 
Since DFGDoesGCCheck is not enabled in Release build, jsc test run in EWS is unrelated. So, since I've ensured that this is built correctly with Release / Debug, I'll land it.
Comment 8 EWS 2020-06-05 18:59:09 PDT 
Committed r262667: <https://trac.webkit.org/changeset/262667>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401199 [details].
Comment 9 Radar WebKit Bug Importer 2020-06-05 19:00:17 PDT 
<rdar://problem/64054916>