m_isEnteringOrExitingPictureInPicture and m_isWaitingForPictureInPictureWindowFrame are only used if VIDEO_PRESENTATION_MODE is enabled, no reason to declare these variable on platforms with VIDEO_PRESENTATION_MODE disabled.
<rdar://problem/64033028>
Created attachment 401166 [details] Patch
IMO you can land things like this as "build fixes" without review if you want.
(In reply to Tim Horton from comment #3) > IMO you can land things like this as "build fixes" without review if you > want. There aren't many this trivial, I'm trying separate these into small enough changes that roll-outs for breaking other builds won't be too painful.
Committed r262633: <https://trac.webkit.org/changeset/262633> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401166 [details].
Comment on attachment 401166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review > Source/WebCore/html/HTMLVideoElement.h:136 > bool m_isChangingPresentationMode { false }; And this variable as well :-)
Comment on attachment 401166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review >> Source/WebCore/html/HTMLVideoElement.h:136 >> bool m_isChangingPresentationMode { false }; > > And this variable as well :-) Actually, m_isChangingPresentationMode is used in webkitDisplayingFullscreen, which isn't guarded by ENABLE(VIDEO_PRESENTATION_MODE).
Comment on attachment 401166 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review >>> Source/WebCore/html/HTMLVideoElement.h:136 >>> bool m_isChangingPresentationMode { false }; >> >> And this variable as well :-) > > Actually, m_isChangingPresentationMode is used in webkitDisplayingFullscreen, which isn't guarded by ENABLE(VIDEO_PRESENTATION_MODE). Oh right!