RESOLVED FIXED 212817
[GTK] MiniBrowser: stop using GtkToolbar for the search bar 
https://bugs.webkit.org/show_bug.cgi?id=212817
Summary [GTK] MiniBrowser: stop using GtkToolbar for the search bar
Carlos Garcia Campos
Reported 2020-06-05 06:00:07 PDT
Use a GtkSearchBar instead, because GtkToolbar is no longer available in GTK4.
Attachments
Patch (17.62 KB, patch)
2020-06-05 06:03 PDT, Carlos Garcia Campos 		aperez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2020-06-05 06:03:14 PDT
Created attachment 401144 [details] Patch
Adrian Perez
Comment 2 2020-06-11 07:15:10 PDT
Comment on attachment 401144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401144&action=review LGTM, but please fix the typos before landing :) > Tools/MiniBrowser/gtk/BrowserSearchBar.c:71 > + action = g_action_map_lookup_action(G_ACTION_MAP(actionGroup), "beginnig-word"); Typo: beginnig → beginning. (The same type is around in a few places more, I won't point out every instance.)
Carlos Garcia Campos
Comment 3 2020-06-12 01:26:06 PDT
Committed r262937: <https://trac.webkit.org/changeset/262937>
Note You need to log in before you can comment on or make changes to this bug.