Bug 212796 - WTF: Exclude MachExceptions.defs from all embedded builds
Summary: WTF: Exclude MachExceptions.defs from all embedded builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-04 19:58 PDT by Jonathan Bedard
Modified: 2020-06-05 09:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2020-06-04 20:11 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2020-06-04 21:18 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-06-04 19:58:53 PDT 
MachExceptions.defs is excluded from OpenSource iPhone builds, and should also be excluded from other OpenSource embedded builds.
Comment 1 Jonathan Bedard 2020-06-04 20:11:09 PDT 
Created attachment 401113 [details]
Patch
Comment 2 Alexey Proskuryakov 2020-06-04 20:48:00 PDT 
Comment on attachment 401113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401113&action=review

> Source/WTF/ChangeLog:10
> +2020-06-04  Jonathan Bedard  <jbedard@apple.com>

Extra change log.

> Source/WTF/Configurations/WTF.xcconfig:-35
> -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks

This seems unrelated.

> Source/WTF/Configurations/WTF.xcconfig:32
> +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK));

This includes simulator, correct?
Comment 3 Jonathan Bedard 2020-06-04 21:18:19 PDT 
Created attachment 401117 [details]
Patch
Comment 4 Jonathan Bedard 2020-06-04 22:02:58 PDT 
(In reply to Alexey Proskuryakov from comment #2)
> Comment on attachment 401113 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401113&action=review
> 
> > Source/WTF/ChangeLog:10
> > +2020-06-04  Jonathan Bedard  <jbedard@apple.com>
> 
> Extra change log.
> 
> > Source/WTF/Configurations/WTF.xcconfig:-35
> > -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks
> 
> This seems unrelated.
> 
> > Source/WTF/Configurations/WTF.xcconfig:32
> > +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK));
> 
> This includes simulator, correct?

It does, this same pattern will show up a few more times in other xcconfig files.
Comment 5 EWS 2020-06-04 22:29:10 PDT 
Committed r262597: <https://trac.webkit.org/changeset/262597>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401117 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-05 09:58:24 PDT 
<rdar://problem/64033297>