Bug 212766 - svn-apply command is too slow with big patches
Summary: svn-apply command is too slow with big patches
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-04 11:26 PDT by Carlos Alberto Lopez Perez
Modified: 2020-06-05 09:27 PDT (History)
12 users (show)

See Also:

Attachments
Patch (8.76 KB, patch)
2020-06-04 11:47 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-06-04 11:26:32 PDT 
I noticed that the tool we use to apply patches (svn-apply) its too slow with large patches.

Check: https://ews.webkit.org/status-bubble/400882
^ click on any of the mac/ios/wpe/gtk bubbles and see how much time it took the step "apply patch"

It took all the EWS systems between 8 and 12 hours!!! to apply that patch.

I admit that the patch in question <https://bugs.webkit.org/attachment.cgi?id=400882> is big (52MB; 29856 files changed), but the time spent to apply it is completely crazy.

This is also not only an issue for the EWS, but also for the commit-queue and for the "webkit-patch land-from-bug" command. Since all of them rely on the script svn-apply to apply patches
Comment 1 Carlos Alberto Lopez Perez 2020-06-04 11:47:49 PDT 
Created attachment 401058 [details]
Patch
Comment 2 Carlos Alberto Lopez Perez 2020-06-04 12:44:37 PDT 
Comment on attachment 401058 [details]
Patch

Clearing flags on attachment: 401058

Committed r262559: <https://trac.webkit.org/changeset/262559>
Comment 3 Carlos Alberto Lopez Perez 2020-06-04 12:44:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-06-04 12:45:18 PDT 
<rdar://problem/63991044>