Bug 212718 - tvOS and watchOS should build with the public SDK
Summary: tvOS and watchOS should build with the public SDK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-03 15:13 PDT by Jonathan Bedard
Modified: 2020-06-12 13:01 PDT (History)
19 users (show)

See Also:

Attachments
Patch (181.57 KB, patch)
2020-06-04 10:03 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-06-03 15:13:57 PDT 
We should add watchOS and tvOS to WebKit's public infrastructure. Of particular interest is EWS.
Comment 1 Jonathan Bedard 2020-06-03 15:14:37 PDT 
<rdar://problem/56477494>
Comment 2 Jonathan Bedard 2020-06-04 10:03:51 PDT 
Created attachment 401032 [details]
Patch
Comment 3 EWS Watchlist 2020-06-04 10:04:58 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Jonathan Bedard 2020-06-04 10:18:34 PDT 
The patch on this bug is being broken up into multiple changes, but should be sufficient to build watchOS and tvOS both Simulator and device with a public SDK.
Comment 5 Jonathan Bedard 2020-06-12 11:45:19 PDT 
Everything has been landed, doing final verification locally before closing this bug.
Comment 6 Jonathan Bedard 2020-06-12 13:00:49 PDT 
I have verified the following all work:
    build-webkit --wathos-device
    build-webkit --wathos-simulator
    build-webkit --tvos-device
    build-webkit --tvos-simulator

CI + EWS has confirmed I haven't broken iOS. I think it's time to close this bug!