Bug 212701 - Text manipulation sometimes fails to replace text in attributes
Summary: Text manipulation sometimes fails to replace text in attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-03 09:17 PDT by Sihui Liu
Modified: 2020-06-03 12:05 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.44 KB, patch)
2020-06-03 09:41 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (6.38 KB, patch)
2020-06-03 11:14 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-06-03 09:17:40 PDT 
...
Comment 1 Sihui Liu 2020-06-03 09:41:57 PDT 
Created attachment 400930 [details]
Patch
Comment 2 Wenson Hsieh 2020-06-03 09:44:27 PDT 
Comment on attachment 400930 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400930&action=review

> Source/WebCore/ChangeLog:11
> +        Coverd by test: TextManipulation.CompleteTextManipulationShouldReplaceTextContentWithMultipleTokens

Nit - covered
Comment 3 Sihui Liu 2020-06-03 11:14:29 PDT 
Created attachment 400947 [details]
Patch for landing
Comment 4 EWS 2020-06-03 12:04:32 PDT 
Committed r262499: <https://trac.webkit.org/changeset/262499>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400947 [details].
Comment 5 Radar WebKit Bug Importer 2020-06-03 12:05:25 PDT 
<rdar://problem/63938348>