Bug 212687 - DFGSSAConversionPhase.cpp needs to #include OperandsInlines.h.
Summary: DFGSSAConversionPhase.cpp needs to #include OperandsInlines.h.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 212680
  Show dependency tree / graph
 
Reported: 2020-06-02 23:02 PDT by Mark Lam
Modified: 2020-06-03 12:59 PDT (History)
10 users (show)

See Also:

Attachments
test for Windows Bot. (595 bytes, patch)
2020-06-02 23:10 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
test patch w/ non-unified build fixes. (41.43 KB, patch)
2020-06-03 00:41 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
test for Windows bot w/ non-unified fixes. (48.29 KB, patch)
2020-06-03 00:47 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
test for Windows bot w/ DFGSSAConversionPhase.cpp #include (35.05 KB, patch)
2020-06-03 10:51 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
test for Windows bot w/ DFGSSAConversionPhase.cpp #include. (35.05 KB, patch)
2020-06-03 10:54 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (1.79 KB, patch)
2020-06-03 12:48 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-06-02 23:02:58 PDT 
...
Comment 1 Mark Lam 2020-06-02 23:10:54 PDT 
Created attachment 400901 [details]
test for Windows Bot.
Comment 2 Mark Lam 2020-06-03 00:41:23 PDT 
Created attachment 400904 [details]
test patch w/ non-unified build fixes.
Comment 3 Mark Lam 2020-06-03 00:47:00 PDT 
Created attachment 400905 [details]
test for Windows bot w/ non-unified fixes.
Comment 4 Mark Lam 2020-06-03 10:51:20 PDT 
Created attachment 400943 [details]
test for Windows bot w/ DFGSSAConversionPhase.cpp #include
Comment 5 Mark Lam 2020-06-03 10:54:27 PDT 
Created attachment 400944 [details]
test for Windows bot w/ DFGSSAConversionPhase.cpp #include.
Comment 6 Mark Lam 2020-06-03 12:48:54 PDT 
Created attachment 400959 [details]
proposed patch.
Comment 7 Keith Miller 2020-06-03 12:50:54 PDT 
Comment on attachment 400959 [details]
proposed patch.

r=me
Comment 8 Mark Lam 2020-06-03 12:58:58 PDT 
Thanks for the review.  Landed in r262510: <http://trac.webkit.org/r262510>.
Comment 9 Radar WebKit Bug Importer 2020-06-03 12:59:16 PDT 
<rdar://problem/63940606>