Bug 212621 - MultiDeleteByOffset should not always def
Summary: MultiDeleteByOffset should not always def
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-01 17:26 PDT by Saam Barati
Modified: 2020-06-02 09:55 PDT (History)
14 users (show)

See Also:

Attachments
patch (6.96 KB, patch)
2020-06-01 17:36 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-06-01 17:26:43 PDT 
Because it doesn't actually always def, it depends on its cases
Comment 1 Saam Barati 2020-06-01 17:27:02 PDT 
<rdar://problem/63824182>
Comment 2 Saam Barati 2020-06-01 17:36:13 PDT 
Created attachment 400774 [details]
patch
Comment 3 Saam Barati 2020-06-01 17:36:47 PDT 
Comment on attachment 400774 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400774&action=review

> Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:-8474
> -            if (variant.newStructure()) {

this is a refactoring, since above, we have the code:

if (!variant.newStructure()) continue;
Comment 4 Yusuke Suzuki 2020-06-02 09:27:53 PDT 
Comment on attachment 400774 [details]
patch

r=me
Comment 5 EWS 2020-06-02 09:55:19 PDT 
Committed r262425: <https://trac.webkit.org/changeset/262425>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400774 [details].