Bug 212613 - Update WPT tests for offscreen-canvas (and rename to html/canvas/offscreen)
Summary: Update WPT tests for offscreen-canvas (and rename to html/canvas/offscreen)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-01 14:36 PDT by Carlos Alberto Lopez Perez
Modified: 2022-02-10 17:10 PST (History)
9 users (show)

See Also:

Attachments
Patch (16.81 MB, patch)
2020-06-01 14:44 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (16.86 MB, patch)
2020-06-02 04:11 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (9.95 MB, patch)
2020-06-04 13:31 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-06-01 14:36:27 PDT 
On WPT the following renaming happened:

    2dcontext -> html/canvas/element
    offscreen-canvas -> html/canvas/offscreen

See: https://github.com/web-platform-tests/wpt/issues/22979


We should re-import this tests and adjust the paths for all expectations accordingly
Comment 1 Carlos Alberto Lopez Perez 2020-06-01 14:44:45 PDT 
Created attachment 400761 [details]
Patch

Ignore for now. Test EWS
Comment 2 Carlos Alberto Lopez Perez 2020-06-02 04:11:07 PDT 
Created attachment 400802 [details]
Patch

Ignore for now. Test EWS
Comment 3 Diego Pino 2020-06-04 03:37:43 PDT 
The 2dcontext tests have been resynced in r262527. After that the offscreen-canvas tests started failing.

I've disabled the offscreen-canvas tests temporarily in https://bugs.webkit.org/show_bug.cgi?id=212738 to make the test bots pass as there were >500 failures.
Comment 4 Carlos Alberto Lopez Perez 2020-06-04 04:13:31 PDT 
re-title bug to re-import the offscreen canvas tests only
Comment 5 Chris Dumez 2020-06-04 08:23:17 PDT 
(In reply to Carlos Alberto Lopez Perez from comment #4)
> re-title bug to re-import the offscreen canvas tests only

Sounds good. Sorry about the conflict, I did not realize someone else was working on resync-ing those tests too.
Comment 6 Carlos Alberto Lopez Perez 2020-06-04 13:11:31 PDT 
(In reply to Chris Dumez from comment #5)
> (In reply to Carlos Alberto Lopez Perez from comment #4)
> > re-title bug to re-import the offscreen canvas tests only
> 
> Sounds good. Sorry about the conflict, I did not realize someone else was
> working on resync-ing those tests too.

No problem :)

It's kind of hard to avoid this conflicts, but they are easy to fix :)

I'm uploading now the patch with the update for offscreen canvas tests. I tested that all of them pass ok in GTK, (WPE should pass; didn't tested)... and the rest of platforms are skipping this tests, so they should be good to go (no need to wait for EWS in this case).
Comment 7 Carlos Alberto Lopez Perez 2020-06-04 13:31:54 PDT 
Created attachment 401074 [details]
Patch
Comment 8 Carlos Alberto Lopez Perez 2020-06-04 18:50:58 PDT 
All EWS green... r?
Comment 9 EWS 2020-06-05 06:53:36 PDT 
Committed r262615: <https://trac.webkit.org/changeset/262615>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401074 [details].
Comment 10 Radar WebKit Bug Importer 2020-06-05 09:57:22 PDT 
<rdar://problem/64033245>
Comment 11 Radar WebKit Bug Importer 2020-06-05 09:57:30 PDT 
<rdar://problem/64033248>