Bug 212577 - Rename Signal::BadAccess to Signal::AccessFault.
Summary: Rename Signal::BadAccess to Signal::AccessFault.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 212575
  Show dependency tree / graph
 
Reported: 2020-05-30 22:41 PDT by Mark Lam
Modified: 2020-05-30 22:56 PDT (History)
10 users (show)

See Also:

Attachments
proposed patch. (6.91 KB, patch)
2020-05-30 22:47 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-05-30 22:41:08 PDT 
This is needed because GTK port's X11 has a #define for BadAccess (in include/X11/X.h):

    #define BadAccess     10    /* depending on context:
                                 - key/button already grabbed
                                 - attempt to free an illegal 
                                   cmap entry 
                                 - attempt to store into a read-only 
                                   color map entry.
                                 - attempt to modify the access control
                                   list from other than the local host.
                                 */

As a result, this breaks the GTK build when wtf/Signals.h is #include'd.
Comment 1 Mark Lam 2020-05-30 22:47:43 PDT 
Created attachment 400695 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2020-05-30 22:52:54 PDT 
Comment on attachment 400695 [details]
proposed patch.

r=me
Comment 3 Mark Lam 2020-05-30 22:55:28 PDT 
Thanks for the review.  Landed in r262355: <http://trac.webkit.org/r262355>.
Comment 4 Radar WebKit Bug Importer 2020-05-30 22:56:18 PDT 
<rdar://problem/63803124>