Bug 212572 - Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platforms that consult touch-action for event handling
Summary: Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platfo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-30 12:36 PDT by Simon Fraser (smfr)
Modified: 2020-06-01 12:39 PDT (History)
20 users (show)

See Also:

Attachments
Patch (14.70 KB, patch)
2020-05-30 12:37 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-05-30 12:36:50 PDT 
Add ENABLE(TOUCH_ACTION_REGIONS) to wrap code that's only relevant for platforms that consult touch-action for event handling
Comment 1 Simon Fraser (smfr) 2020-05-30 12:37:33 PDT 
Created attachment 400675 [details]
Patch
Comment 2 Andy Estes 2020-05-30 12:41:13 PDT 
Comment on attachment 400675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400675&action=review

> Source/WTF/wtf/PlatformEnable.h:491
> +#if !defined(ENABLE_TOUCH_ACTION_REGIONS)
> +#define ENABLE_TOUCH_ACTION_REGIONS 0
> +#endif

Not sure why we have to do this when the default is 0, because !ENABLE_TOUCH_ACTION_REGIONS and !defined(ENABLE_TOUCH_ACTION_REGIONS) is the same as far as the ENABLE() macro is concerned.
Comment 3 EWS 2020-06-01 12:38:40 PDT 
Committed r262390: <https://trac.webkit.org/changeset/262390>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400675 [details].
Comment 4 Radar WebKit Bug Importer 2020-06-01 12:39:16 PDT 
<rdar://problem/63839368>