Bug 212535 - [Cocoa] EME should return more helpful error code during key exchange
Summary: [Cocoa] EME should return more helpful error code during key exchange
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-29 11:10 PDT by Jer Noble
Modified: 2020-05-31 12:52 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2020-05-29 11:17 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (4.26 KB, patch)
2020-05-31 11:53 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-05-29 11:10:10 PDT 
[Cocoa] EME should return more helpful error code during key exchange
Comment 1 Jer Noble 2020-05-29 11:14:13 PDT 
<rdar://problem/60439979>
Comment 2 Jer Noble 2020-05-29 11:17:32 PDT 
Created attachment 400603 [details]
Patch
Comment 3 Eric Carlson 2020-05-29 13:13:20 PDT 
Comment on attachment 400603 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400603&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:1192
> +    // to provide, signal this state by "suceeding", but set the key status

s/suceeding/succeeding/
Comment 4 Jer Noble 2020-05-31 11:53:04 PDT 
Created attachment 400708 [details]
Patch for landing
Comment 5 EWS 2020-05-31 12:52:58 PDT 
Committed r262365: <https://trac.webkit.org/changeset/262365>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400708 [details].