Bug 212452 - Add output file specifications to "Copy Custom WebContent Resources to Framework Private Headers" build phase in WebKit/WebContent
Summary: Add output file specifications to "Copy Custom WebContent Resources to Framew...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-27 19:07 PDT by Keith Rollin
Modified: 2020-05-27 22:53 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.25 KB, patch)
2020-05-27 19:08 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-05-27 19:07:21 PDT
The "Copy Custom WebContent Resources to Framework Private Headers" build phase in the WebContent target of the WebKit project doesn't advertise the files that it produces. This has consequences on later build phases that consume those files. In particular, XCBuild is left not knowing where those files are coming from, and it fails saying that those files don't exist. Fix this by adding the output files to the "output files" section of the custom build phase.
Comment 1 Radar WebKit Bug Importer 2020-05-27 19:07:35 PDT
<rdar://problem/63700546>
Comment 2 Keith Rollin 2020-05-27 19:08:51 PDT
Created attachment 400420 [details]
Patch
Comment 3 EWS 2020-05-27 22:53:21 PDT
Committed r262236: <https://trac.webkit.org/changeset/262236>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400420 [details].