Bug 212355 - [css-flexbox] Tables as flex items should obey the flex container sizing
Summary: [css-flexbox] Tables as flex items should obey the flex container sizing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-25 09:22 PDT by Sergio Villar Senin
Modified: 2020-06-01 08:19 PDT (History)
13 users (show)

See Also:

Attachments
Patch (4.02 KB, patch)
2020-05-25 09:41 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (8.10 KB, patch)
2020-05-25 12:24 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (7.78 KB, patch)
2020-05-25 12:51 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (13.17 KB, patch)
2020-05-26 03:59 PDT, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (13.00 KB, patch)
2020-05-26 04:12 PDT, Sergio Villar Senin 		rego: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2020-05-25 09:22:46 PDT 
[css-flexbox] Tables as flex items should obey the flex container sizing
Comment 1 Sergio Villar Senin 2020-05-25 09:41:32 PDT 
Created attachment 400206 [details]
Patch
Comment 2 Sergio Villar Senin 2020-05-25 12:24:58 PDT 
Created attachment 400213 [details]
Patch

Added another test that passes now
Comment 3 Sergio Villar Senin 2020-05-25 12:51:50 PDT 
Created attachment 400217 [details]
Patch

Fixed duplicated ChangeLog
Comment 4 Sergio Villar Senin 2020-05-26 03:59:26 PDT 
Created attachment 400237 [details]
Patch

New expectations
Comment 5 Sergio Villar Senin 2020-05-26 04:12:51 PDT 
Created attachment 400238 [details]
Patch

Rebased. Fixed conflicts
Comment 6 Sergio Villar Senin 2020-05-26 06:18:53 PDT 
Zalan, Darin could you take a look? Thanks!
Comment 7 Manuel Rego Casasnovas 2020-06-01 07:42:44 PDT 
Comment on attachment 400238 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400238&action=review

The patch looks good to me, just a minor comment inline.

> Source/WebCore/rendering/RenderTable.cpp:284
> +    // is how flexible containers flex or stretch us.

Nit: s/flexible containers/flex container/ (that's the term on the spec so I guess it's better to use it https://drafts.csswg.org/css-flexbox/#flex-containers).
Comment 8 Sergio Villar Senin 2020-06-01 08:18:38 PDT 
Committed r262378: <https://trac.webkit.org/changeset/262378>
Comment 9 Radar WebKit Bug Importer 2020-06-01 08:19:15 PDT 
<rdar://problem/63829730>