Bug 212278 - Make sure we clean up CFTimerRefs when destroying scrolling tree nodes
Summary: Make sure we clean up CFTimerRefs when destroying scrolling tree nodes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-22 13:55 PDT by Simon Fraser (smfr)
Modified: 2020-05-22 14:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.96 KB, patch)
2020-05-22 13:58 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-05-22 13:55:24 PDT 
Make sure we clean up CFTimerRefs when destroying scrolling tree nodes
Comment 1 Simon Fraser (smfr) 2020-05-22 13:58:12 PDT 
Created attachment 400073 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-22 13:58:15 PDT 
<rdar://problem/63548212>
Comment 3 Tim Horton 2020-05-22 13:59:38 PDT 
Comment on attachment 400073 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400073&action=review

> Source/WebCore/page/scrolling/ScrollingTree.cpp:344
> +        iter.value->willBeDestroyed();

This isn't going to mutate the map?
Comment 4 EWS 2020-05-22 14:52:41 PDT 
Committed r262076: <https://trac.webkit.org/changeset/262076>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400073 [details].