Bug 212256 - [GTK] jhbuild is broken with GCC 10.0
Summary: [GTK] jhbuild is broken with GCC 10.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: ChangSeok Oh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-22 02:07 PDT by ChangSeok Oh
Modified: 2020-05-22 10:35 PDT (History)
6 users (show)

See Also:

Attachments
Patch (13.98 KB, patch)
2020-05-22 07:39 PDT, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2020-05-22 02:07:54 PDT 
GCC 10 has -fno-common as default. It causes many multiple definition issues to build dependencies in jhbuild. I know we have moved to flatpak sdk but there may be someone who needs a fix for the issue like me.
Comment 1 ChangSeok Oh 2020-05-22 07:39:40 PDT 
Created attachment 400045 [details]
Patch
Comment 2 ChangSeok Oh 2020-05-22 10:33:24 PDT 
Comment on attachment 400045 [details]
Patch

Thanks for your review!
Comment 3 EWS 2020-05-22 10:35:47 PDT 
Committed r262063: <https://trac.webkit.org/changeset/262063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400045 [details].