WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
ASSIGNED
212123
Web Inspector: Computed: add "filter applied" icon
https://bugs.webkit.org/show_bug.cgi?id=212123
Summary
Web Inspector: Computed: add "filter applied" icon
Nikita Vasilyev
Reported
2020-05-19 21:13:05 PDT
Created
attachment 399806
[details]
[Image] Bug We should add a (...) icon or re-use a gear icon.
Attachments
[Image] Bug
(136.12 KB, image/png)
2020-05-19 21:13 PDT
,
Nikita Vasilyev
no flags
Details
[Image] Filtering in Mail
(6.90 KB, image/png)
2020-06-11 12:06 PDT
,
Nikita Vasilyev
no flags
Details
(...) icon
(1.76 KB, patch)
2020-06-11 12:22 PDT
,
Nikita Vasilyev
nvasilyev
: review-
nvasilyev
: commit-queue-
Details
Formatted Diff
Diff
[Image] With (...) icon
(41.42 KB, image/png)
2020-06-11 12:23 PDT
,
Nikita Vasilyev
no flags
Details
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-05-19 21:13:17 PDT
<
rdar://problem/63429830
>
Nikita Vasilyev
Comment 2
2020-06-11 12:06:00 PDT
Created
attachment 401663
[details]
[Image] Filtering in Mail After making the (...) icon and running with it, I realized that this isn't the best solution either. What we do in Computed section is filtering so the icon is applicable. However, when one of the filters is applied the icon looks exactly the same. This is not how it works on macOS. On the attached image you can see that when filtering is applied, we show "Filtered by: Unread" and the icon is distinctly different. We should do the same for Computed.
Nikita Vasilyev
Comment 3
2020-06-11 12:22:39 PDT
Created
attachment 401665
[details]
(...) icon Here's the unpursued patch. Posting here since I think the icon can be used elsewhere.
Nikita Vasilyev
Comment 4
2020-06-11 12:23:39 PDT
Created
attachment 401666
[details]
[Image] With (...) icon
Devin Rousso
Comment 5
2020-06-11 17:55:28 PDT
We should just create an active (i.e. filled) filter icon. In this case, I think it's accurate for it to use a filter icon as it fundamentally is controlling filters: - "Show All" filters based on whether the property is implicit - "Prefer Shorthands" filters out longhand properties and filters in shorthand properties I think one difference in this case is that the default/initial state is an active filtered state (only showing non-implicit properties, "Show All" is disabled), so we should debate/decide whether the icon should start out active (i.e. filled) or inactive (i.e. hollow).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug