Bug 212113 - [css-grid] computeMarginLogicalSizeForChild checks auto margins in the opposite axis for orthogonal items
Summary: [css-grid] computeMarginLogicalSizeForChild checks auto margins in the opposi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oriol Brufau
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-19 17:03 PDT by Oriol Brufau
Modified: 2020-05-20 00:12 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.39 KB, patch)
2020-05-19 17:16 PDT, Oriol Brufau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oriol Brufau 2020-05-19 17:03:31 PDT 
Like bug 212055, but for computeMarginLogicalSizeForChild.
This makes grid-items-minimum-width-orthogonal-001.html fail some cases.
Comment 1 Oriol Brufau 2020-05-19 17:16:38 PDT 
Created attachment 399786 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2020-05-19 23:57:55 PDT 
Comment on attachment 399786 [details]
Patch

Thanks for the fix, LGTM.
Comment 3 EWS 2020-05-20 00:11:30 PDT 
Committed r261907: <https://trac.webkit.org/changeset/261907>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399786 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-20 00:12:15 PDT 
<rdar://problem/63434636>