Bug 211972 - [Apple Pay] Add testing and logging for ApplePaySetup
Summary: [Apple Pay] Add testing and logging for ApplePaySetup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-15 15:43 PDT by Andy Estes
Modified: 2020-06-09 16:29 PDT (History)
9 users (show)

See Also:

Attachments
Patch (58.95 KB, patch)
2020-05-15 15:48 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (61.78 KB, patch)
2020-05-15 18:00 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (61.48 KB, patch)
2020-05-18 19:39 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch for landing (61.52 KB, patch)
2020-05-18 20:17 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch for landing (61.56 KB, patch)
2020-05-18 20:22 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch for landing (61.60 KB, patch)
2020-05-18 20:28 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch for landing (70.38 KB, patch)
2020-05-19 10:38 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (68.67 KB, patch)
2020-06-05 12:45 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (68.49 KB, patch)
2020-06-05 21:46 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2020-05-15 15:43:39 PDT 
[Apple Pay] Add testing and logging for ApplePaySetup
Comment 1 Radar WebKit Bug Importer 2020-05-15 15:43:59 PDT 
<rdar://problem/63291965>
Comment 2 Andy Estes 2020-05-15 15:48:16 PDT 
Created attachment 399523 [details]
Patch
Comment 3 Andy Estes 2020-05-15 18:00:03 PDT 
Created attachment 399534 [details]
Patch
Comment 4 EWS 2020-05-18 08:11:23 PDT 
Tools/Scripts/svn-apply failed to apply attachment 399534 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 5 Andy Estes 2020-05-18 19:39:32 PDT Comment hidden (obsolete)
Comment 6 Andy Estes 2020-05-18 20:17:10 PDT Comment hidden (obsolete)
Comment 7 Andy Estes 2020-05-18 20:22:55 PDT Comment hidden (obsolete)
Comment 8 Andy Estes 2020-05-18 20:28:50 PDT 
Created attachment 399706 [details]
Patch for landing
Comment 9 EWS 2020-05-19 07:22:09 PDT 
Committed r261858: <https://trac.webkit.org/changeset/261858>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399706 [details].
Comment 10 Andy Estes 2020-05-19 09:15:37 PDT 
Reverted in r261864: <https://trac.webkit.org/changeset/261864>
Comment 11 Andy Estes 2020-05-19 10:38:51 PDT 
Created attachment 399750 [details]
Patch for landing
Comment 12 EWS 2020-05-19 11:19:28 PDT 
Committed r261873: <https://trac.webkit.org/changeset/261873>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399750 [details].
Comment 13 Andy Estes 2020-05-19 13:10:27 PDT 
Reverted again in r261883: <https://trac.webkit.org/changeset/261883>
Comment 14 Andy Estes 2020-06-05 12:45:57 PDT 
Created attachment 401186 [details]
Patch
Comment 15 Andy Estes 2020-06-05 21:46:55 PDT 
Created attachment 401233 [details]
Patch
Comment 16 EWS 2020-06-06 09:13:44 PDT 
Committed r262682: <https://trac.webkit.org/changeset/262682>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401233 [details].
Comment 17 Darin Adler 2020-06-08 13:45:51 PDT 
Comment on attachment 401233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401233&action=review

> Source/WebCore/DerivedSources.make:150
> +	$(WebCore)/Modules/applepay/ApplePaySetupConfiguration.idl \

Should be spaces, not a tab.

> Source/WebCore/DerivedSources.make:152
> +	$(WebCore)/Modules/applepay/ApplePaySetupFeatureState.idl \

Ditto.
Comment 18 Andy Estes 2020-06-09 16:29:00 PDT 
(In reply to Darin Adler from comment #17)
> Comment on attachment 401233 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401233&action=review
> 
> > Source/WebCore/DerivedSources.make:150
> > +	$(WebCore)/Modules/applepay/ApplePaySetupConfiguration.idl \
> 
> Should be spaces, not a tab.
> 
> > Source/WebCore/DerivedSources.make:152
> > +	$(WebCore)/Modules/applepay/ApplePaySetupFeatureState.idl \
> 
> Ditto.

Fixed in r262824: <https://trac.webkit.org/changeset/262824>