Bug 211810 - handling of Check in VarargsForwardingPhase is too pessimistic
Summary: handling of Check in VarargsForwardingPhase is too pessimistic
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-12 15:30 PDT by Saam Barati
Modified: 2020-05-12 20:06 PDT (History)
14 users (show)

See Also:

Attachments
patch (3.34 KB, patch)
2020-05-12 16:03 PDT, Saam Barati 		keith_miller: review+
Details | Formatted Diff | Diff
patch for landing (3.31 KB, patch)
2020-05-12 17:09 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-05-12 15:30:05 PDT 
...
Comment 1 Saam Barati 2020-05-12 16:03:47 PDT 
Created attachment 399194 [details]
patch
Comment 2 Keith Miller 2020-05-12 16:05:39 PDT 
Comment on attachment 399194 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399194&action=review

r=me.

> JSTests/microbenchmarks/forward-varargs-check-shouldnt-escape.js:14
> +// print(Date.now() - start);

Plox delete.
Comment 3 Saam Barati 2020-05-12 17:09:03 PDT 
Created attachment 399205 [details]
patch for landing
Comment 4 EWS 2020-05-12 20:05:01 PDT 
Committed r261595: <https://trac.webkit.org/changeset/261595>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399205 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-12 20:06:13 PDT 
<rdar://problem/63166410>