Bug 211758 - WebGLLayer clobbers TEXTURE_2D binding on iOS
Summary: WebGLLayer clobbers TEXTURE_2D binding on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Darpinian
URL:
Keywords: InRadar
Depends on:
Blocks: 207858 183151
  Show dependency treegraph
 
Reported: 2020-05-11 17:34 PDT by James Darpinian
Modified: 2020-08-21 10:44 PDT (History)
13 users (show)

See Also:


Attachments
Patch (4.66 KB, patch)
2020-05-11 17:37 PDT, James Darpinian
no flags Details | Formatted Diff | Diff
EWS test (5.05 KB, patch)
2020-05-11 18:56 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff
Patch (3.15 KB, patch)
2020-08-20 04:50 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Darpinian 2020-05-11 17:34:26 PDT
WebGLLayer clobbers TEXTURE_2D binding on iOS
Comment 1 James Darpinian 2020-05-11 17:37:53 PDT
Created attachment 399075 [details]
Patch
Comment 2 James Darpinian 2020-05-11 17:53:13 PDT
Fixes tests:
fast/canvas/webgl/webgl-texture-binding-preserved.html
webgl/1.0.3/conformance/canvas/texture-bindings-unaffected-on-resize.html
webgl/1.0.3/conformance/extensions/oes-element-index-uint.html
webgl/1.0.3/conformance/misc/delayed-drawing.html
webgl/1.0.3/conformance/misc/uninitialized-test.html
webgl/1.0.3/conformance/state/state-uneffected-after-compositing.html
webgl/1.0.3/conformance/textures/default-texture.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgb565.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba4444.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas-rgba5551.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-canvas.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgb565.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba4444.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas-rgba5551.html
webgl/1.0.3/conformance/textures/tex-image-and-sub-image-2d-with-webgl-canvas.html
Comment 3 Dean Jackson 2020-05-11 18:56:42 PDT
Created attachment 399085 [details]
EWS test
Comment 4 Dean Jackson 2020-05-11 19:52:21 PDT
Committed r261541: <https://trac.webkit.org/changeset/261541>
Comment 5 Radar WebKit Bug Importer 2020-05-11 19:53:16 PDT
<rdar://problem/63117651>
Comment 6 Kenneth Russell 2020-05-12 08:48:19 PDT
Great work James finding and fixing this!
Comment 7 Kimmo Kinnunen 2020-08-20 04:50:25 PDT
Reopening to attach new patch.
Comment 8 Kimmo Kinnunen 2020-08-20 04:50:28 PDT
Created attachment 406924 [details]
Patch
Comment 9 Kenneth Russell 2020-08-20 09:52:04 PDT
Comment on attachment 406924 [details]
Patch

Hi Kimmo!

This patch looks fine since it's small and didn't mark the old one as obsolete. In the future though please file new bugs and block them on the old ones. WebKit's bug process is best set up for one patch per bug.

Setting r+.
Comment 10 EWS 2020-08-21 10:43:59 PDT
Committed r266009: <https://trac.webkit.org/changeset/266009>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406924 [details].