Bug 211705 - Add copy constructor and assignment operator to Ref<>
Summary: Add copy constructor and assignment operator to Ref<>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-10 16:36 PDT by Darin Adler
Modified: 2020-06-12 13:34 PDT (History)
11 users (show)

See Also:

Attachments
Patch (6.07 KB, patch)
2020-05-10 16:42 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-05-10 16:36:42 PDT 
Add copy constructor and assignment operator to Ref<>
Comment 1 Darin Adler 2020-05-10 16:42:46 PDT 
Created attachment 398986 [details]
Patch
Comment 2 Darin Adler 2020-05-10 16:46:11 PDT 
Comment on attachment 398986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398986&action=review

> Source/WTF/ChangeLog:19
> +        These follow a similar patter to the move constructor and assignment operator.

probably should spell it "pattern".
Comment 3 Chris Dumez 2020-05-10 22:32:10 PDT 
I am glad Ref will finally have this.
Comment 4 Darin Adler 2020-05-10 23:15:01 PDT 
Committed r261467: <https://trac.webkit.org/changeset/261467>
Comment 5 Radar WebKit Bug Importer 2020-05-10 23:15:18 PDT 
<rdar://problem/63077127>
Comment 6 Andreas Kling 2020-06-11 04:24:24 PDT 
Great change! :)

In retrospect, efforts to avoid refcount churn are probably best limited to situations where it has a measurable impact on performance, and should not be a goal in itself.
Comment 7 Darin Adler 2020-06-12 13:34:44 PDT 
Thank you, sir. Great to get a vote of confidence from the "founder of the [Ref class template] feast".