Bug 211673 - [macOS] Search field on mayoclinic.org/forms/us-resident-appointment clips the submit button
Summary: [macOS] Search field on mayoclinic.org/forms/us-resident-appointment clips th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-09 16:10 PDT by Wenson Hsieh
Modified: 2020-05-09 20:05 PDT (History)
13 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2020-05-09 17:42 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for landing (7.71 KB, patch)
2020-05-09 18:51 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch for landing (7.71 KB, patch)
2020-05-09 19:20 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-05-09 16:10:37 PDT 
<rdar://problem/62572501>
Comment 1 Wenson Hsieh 2020-05-09 17:42:47 PDT 
Created attachment 398949 [details]
Patch
Comment 2 Tim Horton 2020-05-09 18:46:47 PDT 
Comment on attachment 398949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398949&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:869
> -    if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == ListboxPart)
> +    if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == SearchFieldPart || style.appearance() == ListboxPart)

At what point do we store appearance in a local to neaten this up?
Comment 3 Wenson Hsieh 2020-05-09 18:48:45 PDT 
Comment on attachment 398949 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398949&action=review

Thanks for the review!

>> Source/WebCore/rendering/RenderThemeMac.mm:869
>> +    if (style.appearance() == TextFieldPart || style.appearance() == TextAreaPart || style.appearance() == SearchFieldPart || style.appearance() == ListboxPart)
> 
> At what point do we store appearance in a local to neaten this up?

Fair point — I’ll go ahead and pull style.appearance() into a local variable while I’m here
Comment 4 Wenson Hsieh 2020-05-09 18:51:17 PDT Comment hidden (obsolete)
Comment 5 Wenson Hsieh 2020-05-09 19:20:36 PDT 
Created attachment 398954 [details]
Patch for landing
Comment 6 EWS 2020-05-09 20:05:44 PDT 
Committed r261450: <https://trac.webkit.org/changeset/261450>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398954 [details].