Bug 211670 - Use std::iterator to implement iterator_category and the other iterator requirements
Summary: Use std::iterator to implement iterator_category and the other iterator requi...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-09 12:43 PDT by Darin Adler
Modified: 2020-05-09 16:20 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.24 KB, patch)
2020-05-09 12:43 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-05-09 12:43:20 PDT
Use std::iterator to implement iterator_category and the other iterator requirements
Comment 1 Darin Adler 2020-05-09 12:43:58 PDT
Created attachment 398935 [details]
Patch
Comment 2 Yusuke Suzuki 2020-05-09 15:57:25 PDT
std::iterator is now deprecated in C++17, and defining these five typedefs in iterator class becomes the recommended way.

    using iterator_category = Category;
    using value_type = T;
    using difference_type = Distance;
    using pointer = Pointer;
    using reference = Reference;

https://www.fluentcpp.com/2018/05/08/std-iterator-deprecated/

It seems that we need to do the opposite thing :), or we should create std::iterator like thing in WTF and replace the current use of std::iterator with that.
Comment 3 Darin Adler 2020-05-09 16:18:04 PDT
OK.

There are 14 places we are using std::iterator.