Bug 211643 - Array.prototype.concat fast path checks should not be observable
Summary: Array.prototype.concat fast path checks should not be observable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-08 14:32 PDT by Alexey Shvayka
Modified: 2020-05-08 18:44 PDT (History)
9 users (show)

See Also:

Attachments
Patch (4.13 KB, patch)
2020-05-08 14:35 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (4.13 KB, patch)
2020-05-08 14:40 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2020-05-08 14:32:06 PDT 
Array.prototype.concat fast path checks should not be observable
Comment 1 Alexey Shvayka 2020-05-08 14:35:32 PDT 
Created attachment 398889 [details]
Patch
Comment 2 Alexey Shvayka 2020-05-08 14:40:56 PDT 
Created attachment 398890 [details]
Patch

Tweak ChangeLog.
Comment 3 Ross Kirsling 2020-05-08 14:43:16 PDT 
Comment on attachment 398890 [details]
Patch

Nice, glad to see that intrinsic is coming in handy. :)
Comment 4 Alexey Shvayka 2020-05-08 17:02:51 PDT 
(In reply to Ross Kirsling from comment #3)
> Comment on attachment 398890 [details]
> Patch
> 
> Nice, glad to see that intrinsic is coming in handy. :)

Good job on implementing it and thanks for review!
ARMv7 failure is unrelated: https://webkit.org/b/211313.
Comment 5 EWS 2020-05-08 18:43:47 PDT 
Committed r261430: <https://trac.webkit.org/changeset/261430>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398890 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-08 18:44:16 PDT 
<rdar://problem/63044859>