Bug 211634 - [clang-tidy] Run modernize-use-using over WTF
Summary: [clang-tidy] Run modernize-use-using over WTF
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-08 11:57 PDT by Don Olmstead
Modified: 2020-05-08 13:40 PDT (History)
5 users (show)

See Also:


Attachments
WIP Patch (75.41 KB, patch)
2020-05-08 11:58 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2020-05-08 11:57:59 PDT
...
Comment 1 Don Olmstead 2020-05-08 11:58:42 PDT
Created attachment 398878 [details]
WIP Patch
Comment 2 Don Olmstead 2020-05-08 12:01:59 PDT
Current problematic constructs with the modernizer.

Had some issues with these typedefs

-    typedef T* (PackedAlignedPtr::*UnspecifiedBoolType);
+    using UnspecifiedBoolType = T *(PackedAlignedPtr<T, >::*);

It will totally destroy typedef enum code but we probably shouldn't be using those constructs anyways.

typedef enum {
    LenientConversion,
    StrictConversion,
    StrictConversionReplacingUnpairedSurrogatesWithFFFD,
} ConversionMode;

Did have some issues with removing typedefs in Variant.h
Comment 3 Darin Adler 2020-05-08 13:40:13 PDT
Could do a quick pass first to remove all the "typedef enum" in the tree: Should be a mechanical process.