Bug 211567 - Make debug build run in accessibility isolated mode = 1.
Summary: Make debug build run in accessibility isolated mode = 1.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-07 07:00 PDT by Andres Gonzalez
Modified: 2020-05-07 09:52 PDT (History)
9 users (show)

See Also:


Attachments
Patch (8.41 KB, patch)
2020-05-07 07:14 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff
Patch (10.41 KB, patch)
2020-05-07 09:13 PDT, Andres Gonzalez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-05-07 07:00:58 PDT
Make debug build run in accessibility isolated mode = 1.
Comment 1 Andres Gonzalez 2020-05-07 07:14:02 PDT
Created attachment 398735 [details]
Patch
Comment 2 chris fleizach 2020-05-07 07:26:32 PDT
Comment on attachment 398735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398735&action=review

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:-481
> -    if (!isMainThread()) {

Can we leave this !iSMainThread but check which isolated tree mode we're in? and better yet add another assert?

> Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:860
> +    if (auto tree = this->tree())

same here

> Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:290
> +    ASSERT(m_changeLogLock.isLocked());

do we need to add the same thing for the focused node?
Comment 3 Andres Gonzalez 2020-05-07 09:13:56 PDT
Created attachment 398742 [details]
Patch
Comment 4 EWS 2020-05-07 09:51:08 PDT
Committed r261300: <https://trac.webkit.org/changeset/261300>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398742 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-07 09:52:14 PDT
<rdar://problem/62980582>