Bug 211553 - [GTK4] Stop using the GtkWidget.destroy vfunc
Summary: [GTK4] Stop using the GtkWidget.destroy vfunc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-05-07 01:04 PDT by Adrian Perez
Modified: 2020-05-07 02:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.76 KB, patch)
2020-05-07 01:12 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-05-07 01:04:04 PDT 
The GtkWidget.destroy vfunc is no more, and GObject.dispose should
be used instead after the following merge request landed into GTK4:

  https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1835

We only use .destroy in WebKitWebViewBase, and it looks like it
should be possible to stop using .destroy for both GTK3 and GTK4 =)
Comment 1 Adrian Perez 2020-05-07 01:12:23 PDT 
Created attachment 398711 [details]
Patch
Comment 2 EWS Watchlist 2020-05-07 01:13:01 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 EWS 2020-05-07 02:05:40 PDT 
Committed r261276: <https://trac.webkit.org/changeset/261276>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398711 [details].