Bug 211406 - block-spammers tool should hide attachments
Summary: block-spammers tool should hide attachments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-04 15:08 PDT by Alexey Proskuryakov
Modified: 2020-05-19 10:24 PDT (History)
3 users (show)

See Also:

Attachments
proposed patch (6.04 KB, patch)
2020-05-04 15:11 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2020-05-04 15:08:16 PDT 
Unclear why spammers add attachments, yet they do.

Bugzilla can delete attachments, but there is no API for that, and the manual process takes two form submissions, which is particularly fragile to automate. I guess hiding is good enough.
Comment 1 Alexey Proskuryakov 2020-05-04 15:11:19 PDT 
Created attachment 398424 [details]
proposed patch
Comment 2 Darin Adler 2020-05-04 15:55:26 PDT 
Sounds good to me.
Comment 3 EWS 2020-05-04 17:09:08 PDT 
Committed r261128: <https://trac.webkit.org/changeset/261128>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398424 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-04 17:10:16 PDT 
<rdar://problem/62868426>
Comment 5 Darin Adler 2020-05-04 17:33:04 PDT 
I used block-spammers this weekend. I wonder who else is using it besides you and me, Alexey.
Comment 6 Alexey Proskuryakov 2020-05-04 17:46:51 PDT 
Unsure. Maybe Dave Kilzer sometimes? It saves time for me, and improves accuracy.
Comment 7 Darin Adler 2020-05-04 19:58:19 PDT 
Yes, I like it!
Comment 8 David Kilzer (:ddkilzer) 2020-05-19 10:24:30 PDT 
(In reply to Alexey Proskuryakov from comment #6)
> Unsure. Maybe Dave Kilzer sometimes? It saves time for me, and improves
> accuracy.

I've never used it, but I'll try to remember to use it the next time I see spam.