Bug 211387 - Allow SharedBuffer to be backed by SharedMemory.
Summary: Allow SharedBuffer to be backed by SharedMemory.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-04 10:06 PDT by Jer Noble
Modified: 2020-05-04 14:02 PDT (History)
1 user (show)

See Also:

Attachments
WIP (241.98 KB, patch)
2020-05-04 10:08 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-05-04 10:06:11 PDT 
Allow SharedBuffer to be backed by SharedMemory.
Comment 1 Jer Noble 2020-05-04 10:06:33 PDT 
This will require moving SharedMemory (and also Attachment and MachPort) into PAL.
Comment 2 Jer Noble 2020-05-04 10:08:17 PDT 
Created attachment 398384 [details]
WIP
Comment 3 Alex Christensen 2020-05-04 10:16:14 PDT 
Comment on attachment 398384 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=398384&action=review

> Source/WebCore/PAL/SharedMemory.h:59
> +class SharedMemory : public RefCounted<SharedMemory> {

Why are there two SharedMemory.h?

> Source/WebKit/Platform/SharedMemory.h:29
> +#include <pal/system/SharedMemory.h>

We should remove this header whose only purpose is to include another.
Comment 4 Jer Noble 2020-05-04 13:56:16 PDT 
(In reply to Alex Christensen from comment #3)
> Comment on attachment 398384 [details]
> WIP
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398384&action=review
> 
> > Source/WebCore/PAL/SharedMemory.h:59
> > +class SharedMemory : public RefCounted<SharedMemory> {
> 
> Why are there two SharedMemory.h?
> 
> > Source/WebKit/Platform/SharedMemory.h:29
> > +#include <pal/system/SharedMemory.h>
> 
> We should remove this header whose only purpose is to include another.

That was a failed experiment to try to reduce the number of changes needed inside of Source/WebKit/. Yeah, it's not necessary.
Comment 5 Alex Christensen 2020-05-04 14:02:45 PDT 
Comment on attachment 398384 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=398384&action=review

> Source/WebCore/DerivedSources-input.xcfilelist:1190
> +ApplePaySetupFeatureType.idl

Also this should not be in this patch.  If it's needed it should be separate.