Bug 211383 - [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks
Summary: [Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-04 09:03 PDT by Darin Adler
Modified: 2020-05-04 18:04 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.88 KB, patch)
2020-05-04 09:05 PDT, Darin Adler 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-05-04 09:03:51 PDT 
[Cocoa] Remove a few unneeded __IPHONE_OS_VERSION_MIN_REQUIRED checks
Comment 1 Darin Adler 2020-05-04 09:05:45 PDT 
Created attachment 398373 [details]
Patch
Comment 2 Alexey Proskuryakov 2020-05-04 16:32:37 PDT 
Comment on attachment 398373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review

> Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV)

This check can be removed now, 10.14 is the oldest supported version for macOS.

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534
>  #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400

This can be removed too. We are 13.4+ now.
Comment 3 Darin Adler 2020-05-04 17:33:55 PDT 
All right. I have some more patches coming up removing even more version checks.
Comment 4 Darin Adler 2020-05-04 18:01:32 PDT 
Comment on attachment 398373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398373&action=review

>> Tools/TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:151
>> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV)
> 
> This check can be removed now, 10.14 is the oldest supported version for macOS.

OK, will do.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:6534
>>  #if __IPHONE_OS_VERSION_MIN_REQUIRED > 130400
> 
> This can be removed too. We are 13.4+ now.

Are you sure? This says > 130400, not >= 130400.
Comment 5 Darin Adler 2020-05-04 18:03:16 PDT 
Committed r261134: <https://trac.webkit.org/changeset/261134>
Comment 6 Radar WebKit Bug Importer 2020-05-04 18:04:18 PDT 
<rdar://problem/62870095>