Bug 211345 - WebGPU: Textures should be able to have OUTPUT_ATTACHEMENT | SAMPLED usage flags
Summary: WebGPU: Textures should be able to have OUTPUT_ATTACHEMENT | SAMPLED usage flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: gvinals
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-02 18:58 PDT by gvinals
Modified: 2020-05-04 11:18 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.16 KB, patch)
2020-05-03 19:23 PDT, gvinals
mmaxfield: review+
Details | Formatted Diff | Diff
Patch for committing (4.27 KB, patch)
2020-05-04 10:26 PDT, gvinals
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gvinals 2020-05-02 18:58:41 PDT
Summary:
WebGPU: Textures should be able to have OUTPUT_ATTACHEMENT | SAMPLED usage flags.

All real GPU workloads will have multiple passes in order to render a scene. Most of this passes (except for the final on-screen pass) will happen in the intermediate render targets. An intermediate render target is both a texture that you render to and a texture that you sample from.

This is necessary for just about every rendering technique: Shadow maps, tone mapping, bloom, etc…
Comment 1 gvinals 2020-05-02 19:00:05 PDT
<rdar://problem/62264423>
Comment 2 gvinals 2020-05-03 19:23:25 PDT
Created attachment 398343 [details]
Patch
Comment 3 gvinals 2020-05-04 10:26:04 PDT
Created attachment 398387 [details]
Patch for committing
Comment 4 EWS 2020-05-04 10:27:18 PDT
gvinals@apple.com does not have committer permissions according to https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 398387 [details] from commit queue.
Comment 5 EWS 2020-05-04 11:18:34 PDT
Committed r261091: <https://trac.webkit.org/changeset/261091>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398387 [details].