Bug 211278 - Reduce data copies in the WebContent process custom URL scheme handler
Summary: Reduce data copies in the WebContent process custom URL scheme handler
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-30 22:16 PDT by Jer Noble
Modified: 2020-05-01 12:55 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.97 KB, patch)
2020-04-30 22:21 PDT, Jer Noble 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2020-04-30 22:16:35 PDT 
Reduce data copies in the WebContent process custom URL scheme handler
Comment 1 Jer Noble 2020-04-30 22:21:50 PDT 
Created attachment 398160 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-04-30 22:23:50 PDT 
<rdar://problem/62702860>
Comment 3 Daniel Bates 2020-05-01 12:55:09 PDT 
Comment on attachment 398160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398160&action=review

Patch looks good.

> Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.h:62
> +    void taskDidReceiveBuffer(uint64_t taskIdentifier, Ref<WebCore::SharedBuffer>&& data);

Ok as is. No change needed. Optimal solution doesn't name the buffer arg.