Bug 211269 - [iOS] Fix confusing idiom for releasing _selectionRects in -[WKTextRange dealloc]
Summary: [iOS] Fix confusing idiom for releasing _selectionRects in -[WKTextRange deal...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-30 18:23 PDT by David Kilzer (:ddkilzer)
Modified: 2022-09-17 17:23 PDT (History)
3 users (show)

See Also:

Attachments
Patch v1 (1.45 KB, patch)
2020-04-30 18:24 PDT, David Kilzer (:ddkilzer) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-30 18:23:15 PDT 
Fix confusing idiom for releasing _selectionRects in -[WKTextRange dealloc].

This fixes a false positive warning from the clang static analyzer about releasing a variable not owned by the caller.
Comment 1 David Kilzer (:ddkilzer) 2020-04-30 18:24:08 PDT 
Created attachment 398130 [details]
Patch v1
Comment 2 David Kilzer (:ddkilzer) 2020-04-30 20:24:16 PDT 
Comment on attachment 398130 [details]
Patch v1

This is a WK2-only patch, so marking cq+ before mac-debug-wk1 tests are run (skipped).
Comment 3 EWS 2020-04-30 20:26:25 PDT 
Committed r260980: <https://trac.webkit.org/changeset/260980>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398130 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-30 20:27:13 PDT 
<rdar://problem/62697108>