Bug 211239 - [GStreamer] Move video frame holder to its own file
Summary: [GStreamer] Move video frame holder to its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-30 10:05 PDT by Philippe Normand
Modified: 2020-05-01 01:17 PDT (History)
16 users (show)

See Also:

Attachments
Patch (26.42 KB, patch)
2020-04-30 10:10 PDT, Philippe Normand 		achristensen: review+
calvaris: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-04-30 10:05:58 PDT 
Refactoring.
Comment 1 Philippe Normand 2020-04-30 10:10:27 PDT 
Created attachment 398060 [details]
Patch
Comment 2 Xabier Rodríguez Calvar 2020-04-30 23:22:43 PDT 
Comment on attachment 398060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398060&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameHolder.cpp:8
> + * Copyright (C) 2007, 2009 Apple Inc.  All rights reserved.
> + * Copyright (C) 2007 Collabora Ltd.  All rights reserved.
> + * Copyright (C) 2007 Alp Toker <alp@atoker.com>
> + * Copyright (C) 2009 Gustavo Noronha Silva <gns@gnome.org>
> + * Copyright (C) 2014 Cable Television Laboratories, Inc.
> + * Copyright (C) 2009, 2019, 2020 Igalia S.L
> + * Copyright (C) 2015, 2019 Metrological Group B.V.

This should be 2019 Igalia and Metro. The other holders don't belong here.

> Source/WebCore/platform/graphics/gstreamer/GStreamerVideoFrameHolder.cpp:104
> +            // Right now the TextureMapper only supports chromas with one plane

.
Comment 3 Philippe Normand 2020-05-01 01:16:11 PDT 
Committed r260987: <https://trac.webkit.org/changeset/260987>
Comment 4 Radar WebKit Bug Importer 2020-05-01 01:17:17 PDT 
<rdar://problem/62711074>