Bug 211222 - Web views should use black fill color before first paint on watchOS
Summary: Web views should use black fill color before first paint on watchOS
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Savage
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-29 22:14 PDT by James Savage
Modified: 2022-02-09 10:14 PST (History)
14 users (show)

See Also:


Attachments
Patch (1.72 KB, patch)
2020-04-30 18:36 PDT, James Savage
no flags Details | Formatted Diff | Diff
Patch (3.18 KB, patch)
2020-04-30 18:40 PDT, James Savage
no flags Details | Formatted Diff | Diff
Patch (11.80 KB, patch)
2020-05-13 20:48 PDT, James Savage
james.savage: review?
james.savage: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Savage 2020-04-29 22:14:25 PDT
This better matches the platform and avoid flickering.
<rdar://problem/58652428>
Comment 1 James Savage 2020-04-30 18:36:46 PDT
Created attachment 398132 [details]
Patch
Comment 2 James Savage 2020-04-30 18:40:33 PDT
Created attachment 398135 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-04-30 20:38:47 PDT
Comment on attachment 398135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398135&action=review

> Source/WebCore/page/FrameView.cpp:2990
> +#elif PLATFORM(WATCHOS)

Can we do this without a platform #ifdef in this cross-platform file?

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:540
> +    [self setBackgroundColor:[UIColor blackColor]];

What if the client has set _drawsBackground to NO?
Comment 4 Simon Fraser (smfr) 2020-04-30 20:41:43 PDT
Comment on attachment 398135 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398135&action=review

> Source/WebKit/ChangeLog:11
> +        the background color for web views. This will then get propogated to

propogated
Comment 5 James Savage 2020-05-13 20:48:48 PDT
Created attachment 399329 [details]
Patch
Comment 6 Sam Weinig 2020-05-14 09:24:55 PDT
Comment on attachment 399329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399329&action=review

> Source/WebCore/style/UserAgentStyle.cpp:101
> +#define SYSTEM_BACKGROUND_COLOR "html{background-color: white;}"

no need for the space or ;