Bug 211208 - make_names.pl should accept another file which just generates misc names additionally
Summary: make_names.pl should accept another file which just generates misc names addi...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-29 14:40 PDT by Yusuke Suzuki
Modified: 2020-04-29 22:54 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-29 14:40:59 PDT 
There are so many adhoc `static NeverDestroyed<const AtomString> ...` things in WebCore code and sometimes we are doing `AtomString { ..., AtomString::CreateFromLiteral }` in a critical path.
Comment 1 Yusuke Suzuki 2020-04-29 22:52:36 PDT 
After considering about this, I'm currently not sure whether this is better. Since NeverDestroyed<AtomString> can lazily initialize it, (maybe does not matter much).
Comment 2 Yusuke Suzuki 2020-04-29 22:54:24 PDT 
I have a patch for this, but I'll first do a simpler one, use NeverDestroyed<AtomString> instead of constructing AtomString every time.