Bug 211204 - build-jsc should quote the value of compile flags it forwards
Summary: build-jsc should quote the value of compile flags it forwards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-29 13:56 PDT by Saam Barati
Modified: 2020-04-29 14:58 PDT (History)
14 users (show)

See Also:

Attachments
patch (1.92 KB, patch)
2020-04-29 14:16 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-04-29 13:56:09 PDT 
For example, we do the wrong thing now with make when doing
$ build-jsc --release ARCHS="x86_64 i386"
We invoke make as
$ make release ARCHS=x86_64 i386
instead of
$ make release ARCHS="x86_64 i386"
Comment 1 Saam Barati 2020-04-29 14:16:45 PDT 
Created attachment 397997 [details]
patch
Comment 2 Mark Lam 2020-04-29 14:25:00 PDT 
Comment on attachment 397997 [details]
patch

rs=me
Comment 3 EWS 2020-04-29 14:57:46 PDT 
Committed r260917: <https://trac.webkit.org/changeset/260917>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397997 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-29 14:58:14 PDT 
<rdar://problem/62619195>