Bug 211108 - Web Inspector: Use standardized `:is` CSS selector instead of `:matches`
Summary: Web Inspector: Use standardized `:is` CSS selector instead of `:matches`
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-27 17:31 PDT by Nikita Vasilyev
Modified: 2020-04-28 12:09 PDT (History)
2 users (show)

See Also:

Attachments
Patch (109.81 KB, patch)
2020-04-27 17:41 PDT, Nikita Vasilyev 		hi: review-
hi: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-04-27 17:31:26 PDT 
CSS Selectors Level 4 defines `:is` selector. https://www.w3.org/TR/selectors-4/#matches

`:matches` is a deprecated alias for it. https://github.com/w3c/csswg-drafts/issues/3258

This is refactoring; it should have no user effects.
Comment 1 Nikita Vasilyev 2020-04-27 17:41:05 PDT 
Created attachment 397772 [details]
Patch
Comment 2 Devin Rousso 2020-04-28 12:09:17 PDT 
Comment on attachment 397772 [details]
Patch

r-, as since `:matches` is allowed as an obsolete alias for `:is` there's no need to remove it.  We should just prefer using `:is` going forward, and change previous uses as we come across them (same as how we treat usage of `var`).