Bug 211090 - Make HistoryController an inner class of FrameLoader
Summary: Make HistoryController an inner class of FrameLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-27 13:11 PDT by Rob Buis
Modified: 2020-04-28 02:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (20.41 KB, patch)
2020-04-27 13:15 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (20.87 KB, patch)
2020-04-28 01:19 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-04-27 13:11:19 PDT 
Make HistoryController an inner class of FrameLoader, this allows us to move some methods
only used by HistoryController out of the FrameLoader public API.
Comment 1 Rob Buis 2020-04-27 13:15:26 PDT 
Created attachment 397725 [details]
Patch
Comment 2 Rob Buis 2020-04-27 14:24:31 PDT 
Comment on attachment 397725 [details]
Patch

PTAL. If this kind of design is acceptable I'd like to do the same for PolicyChecker and DocumentLoader, as especially the latter adds a lot of public API to FrameLoader that is only used by DocumentLoader, which could be made private. These classes all look tightly coupled to me BTW.
Comment 3 Darin Adler 2020-04-27 14:30:38 PDT 
Comment on attachment 397725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397725&action=review

> Source/WebCore/loader/HistoryController.h:32
> -#include "FrameLoaderTypes.h"
> +#include "FrameLoader.h"

I’d think you could remove many of the includes below after making this change.
Comment 4 Rob Buis 2020-04-28 01:19:12 PDT 
Created attachment 397819 [details]
Patch
Comment 5 EWS 2020-04-28 02:11:50 PDT 
Committed r260812: <https://trac.webkit.org/changeset/260812>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397819 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-28 02:12:18 PDT 
<rdar://problem/62499688>