Bug 210997 - REGRESSION(260485) Payment requests don't do anything
Summary: REGRESSION(260485) Payment requests don't do anything
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-24 15:19 PDT by Alex Christensen
Modified: 2020-04-24 16:32 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.63 KB, patch)
2020-04-24 15:21 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-04-24 15:19:07 PDT 
REGRESSION(260485) Payment requests don't do anything
Comment 1 Alex Christensen 2020-04-24 15:21:47 PDT 
Created attachment 397515 [details]
Patch
Comment 2 Alex Christensen 2020-04-24 15:21:50 PDT 
<rdar://problem/62275343>
Comment 3 Darin Adler 2020-04-24 16:04:29 PDT 
Comment on attachment 397515 [details]
Patch

I would have fixed this with a lambda at the call site rather than a makeNSArrayElement in URL.h. But this fix is OK too.
Comment 4 Alex Christensen 2020-04-24 16:05:40 PDT 
I think this will prevent future bugs.  I'm also working to reduce use of then remove URL's operator String.
Comment 5 EWS 2020-04-24 16:32:08 PDT 
Committed r260679: <https://trac.webkit.org/changeset/260679>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397515 [details].