Bug 210996 - Call addExtraFieldsToRequest with current load type
Summary: Call addExtraFieldsToRequest with current load type
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-24 14:18 PDT by Rob Buis
Modified: 2021-12-13 02:05 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2020-04-24 14:20 PDT, Rob Buis 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-04-24 14:18:16 PDT 
Call addExtraFieldsToRequest with current load type, not the previous load type.
Comment 1 Rob Buis 2020-04-24 14:20:18 PDT 
Created attachment 397508 [details]
Patch
Comment 2 Darin Adler 2020-04-24 16:32:03 PDT 
Comment on attachment 397508 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397508&action=review

> Source/WebCore/ChangeLog:8
> +        Call addExtraFieldsToRequest with current load type, not the previous load type.

Is there any observable progression from this? If so, can we make a test demonstrating it?

> Source/WebCore/loader/FrameLoader.cpp:1520
> +    ResourceRequest& request = newDocumentLoader.request();

I would have suggested auto& here.