Bug 210980 - Fix WASM Error classes and re-sync wpt/wasm/jsapi from upstream
Summary: Fix WASM Error classes and re-sync wpt/wasm/jsapi from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Minor
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
: 204054 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-24 11:22 PDT by Alexey Shvayka
Modified: 2023-03-07 16:52 PST (History)
12 users (show)

See Also:

Attachments
Patch (284.12 KB, patch)
2020-04-24 12:00 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Patch (286.81 KB, patch)
2020-04-24 14:30 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2020-04-24 11:22:18 PDT 
Fix WASM Error classes and re-sync wpt/wasm/jsapi from upstream
Comment 1 Alexey Shvayka 2020-04-24 12:00:59 PDT 
Created attachment 397479 [details]
Patch
Comment 2 Keith Miller 2020-04-24 12:08:32 PDT 
Comment on attachment 397479 [details]
Patch

r=me.
Comment 3 Keith Miller 2020-04-24 12:10:27 PDT 
Comment on attachment 397479 [details]
Patch

Err, let's wait for EWS to run first.
Comment 4 Alexey Shvayka 2020-04-24 12:17:00 PDT 
(In reply to Keith Miller from comment #3)
> Comment on attachment 397479 [details]
> Patch
> 
> Err, let's wait for EWS to run first.

Absolutely: it is easy to miss a file from staging or update platform-related expectations.

Thank you for review, Keith.
Comment 5 Alexey Shvayka 2020-04-24 14:30:02 PDT 
Created attachment 397509 [details]
Patch

Set reviewer and adjust WASM tests.
Comment 6 EWS 2020-04-24 21:58:42 PDT 
Committed r260690: <https://trac.webkit.org/changeset/260690>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397509 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-24 21:59:14 PDT 
<rdar://problem/62361454>
Comment 8 Myles C. Maxfield 2020-04-24 22:59:49 PDT 
This patch broke Apple's internal builds.
Comment 9 Yusuke Suzuki 2020-04-24 23:14:59 PDT 
(In reply to Myles C. Maxfield from comment #8)
> This patch broke Apple's internal builds.

https://bugs.webkit.org/show_bug.cgi?id=211011
Comment 10 Yusuke Suzuki 2023-03-07 16:52:56 PST 
*** Bug 204054 has been marked as a duplicate of this bug. ***