Bug 210950 - Disable useKernTCSM=false for JSC stress tests to make EWS faster
Summary: Disable useKernTCSM=false for JSC stress tests to make EWS faster
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-23 18:03 PDT by Yusuke Suzuki
Modified: 2020-04-24 06:15 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2020-04-23 18:07 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2020-04-23 18:03:39 PDT 
Disable useKernTCSM=false for JSC stress tests to make EWS faster
Comment 1 Yusuke Suzuki 2020-04-23 18:07:23 PDT 
Created attachment 397410 [details]
Patch
Comment 2 Yusuke Suzuki 2020-04-23 18:08:16 PDT 
Comment on attachment 397410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review

> Tools/Scripts/run-javascriptcore-tests:-532
> -}

I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first.
Comment 3 Yusuke Suzuki 2020-04-23 19:09:59 PDT 
EWS JSC stress bot finishes with 59:23, so this patch is effective.
Comment 4 Yusuke Suzuki 2020-04-23 19:10:28 PDT 
Comment on attachment 397410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review

>> Tools/Scripts/run-javascriptcore-tests:-532
>> -}
> 
> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first.

I've ensured this works on EWS.
Comment 5 Mark Lam 2020-04-23 20:21:02 PDT 
Comment on attachment 397410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review

r=me

>>> Tools/Scripts/run-javascriptcore-tests:-532
>>> -}
>> 
>> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first.
> 
> I've ensured this works on EWS.

Jonathan Bedard (cc'ed) added this change.  I'm fine with removing it since we have evidence that it speeds up the EWS.
Comment 6 EWS 2020-04-23 20:31:14 PDT 
Committed r260617: <https://trac.webkit.org/changeset/260617>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397410 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-23 20:32:14 PDT 
<rdar://problem/62278398>
Comment 8 Jonathan Bedard 2020-04-24 06:15:47 PDT 
Comment on attachment 397410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397410&action=review

>>>> Tools/Scripts/run-javascriptcore-tests:-532
>>>> -}
>>> 
>>> I'm not sure whether webkitpy's JSC_useKernTCSM also affects on EWS. So I would like to check the environment variables in EWS first.
>> 
>> I've ensured this works on EWS.
> 
> Jonathan Bedard (cc'ed) added this change.  I'm fine with removing it since we have evidence that it speeds up the EWS.

I would agree. I have evidence JSC_useKernTCSM=false speeds up layout tests, but never had evidence for JSC tests.