Bug 210879 - AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet
Summary: AX: Improve tracking of Element* pointers in AXObjectCache with WeakHashSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-22 14:58 PDT by chris fleizach
Modified: 2020-04-25 10:03 PDT (History)
8 users (show)

See Also:

Attachments
patch (4.55 KB, patch)
2020-04-22 14:59 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (3.81 KB, patch)
2020-04-25 00:13 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (4.03 KB, patch)
2020-04-25 00:14 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2020-04-22 14:58:30 PDT 
Realized we could make use of WeakHashSet


<rdar://problem/58383764>
Comment 1 chris fleizach 2020-04-22 14:59:30 PDT 
Created attachment 397268 [details]
patch
Comment 2 chris fleizach 2020-04-25 00:13:32 PDT 
Created attachment 397546 [details]
patch
Comment 3 chris fleizach 2020-04-25 00:14:52 PDT 
Created attachment 397547 [details]
patch
Comment 4 Daniel Bates 2020-04-25 08:06:06 PDT 
Comment on attachment 397547 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397547&action=review

Patch looks good.

> Source/WebCore/accessibility/AXObjectCache.h:490
> +    WeakHashSet<Element> m_deferredRecomputeIsIgnoredList;

This is a behavior change: weak set is UNORDERED, but list set is ORDERED. Is this OK?
Comment 5 EWS 2020-04-25 10:03:36 PDT 
Committed r260706: <https://trac.webkit.org/changeset/260706>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397547 [details].