Bug 210857 - [iOS] Add a quirk to keep gizmodo videos visible when playing in fullscreen.
Summary: [iOS] Add a quirk to keep gizmodo videos visible when playing in fullscreen.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-22 07:40 PDT by Eric Carlson
Modified: 2020-04-22 11:38 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.66 KB, patch)
2020-04-22 07:53 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (7.85 KB, patch)
2020-04-22 09:21 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (7.84 KB, patch)
2020-04-22 09:26 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2020-04-22 07:40:19 PDT 
Don't allow `display:none` on a video element ancestor when in fullscreen.
Comment 1 Eric Carlson 2020-04-22 07:42:26 PDT 
<rdar://problem/58875327>
Comment 2 Eric Carlson 2020-04-22 07:53:57 PDT 
Created attachment 397189 [details]
Patch
Comment 3 Darin Adler 2020-04-22 08:43:40 PDT 
Comment on attachment 397189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397189&action=review

> Source/WebCore/style/StyleAdjuster.cpp:37
> +#include "HTMLDivElement.h"

Also need to include "HTMLVideoElement.h".

> Source/WebCore/style/StyleAdjuster.cpp:565
> +                if (video && is<HTMLVideoElement>(video) && downcast<HTMLVideoElement>(*video).isFullscreen())

No needful the "video &&" part, since is<>(video) does a null check.
Comment 4 Eric Carlson 2020-04-22 09:21:52 PDT 
Created attachment 397202 [details]
Patch
Comment 5 Eric Carlson 2020-04-22 09:26:52 PDT 
Created attachment 397206 [details]
Patch
Comment 6 Eric Carlson 2020-04-22 09:45:49 PDT 
Comment on attachment 397189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397189&action=review

>> Source/WebCore/style/StyleAdjuster.cpp:565
>> +                if (video && is<HTMLVideoElement>(video) && downcast<HTMLVideoElement>(*video).isFullscreen())
> 
> No needful the "video &&" part, since is<>(video) does a null check.

Good point, thanks.
Comment 7 EWS 2020-04-22 11:38:41 PDT 
Committed r260524: <https://trac.webkit.org/changeset/260524>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397206 [details].