Bug 210781 - logLevelString() is declared in both LogInitialization.h and in Logging.h
Summary: logLevelString() is declared in both LogInitialization.h and in Logging.h
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-20 20:30 PDT by David Kilzer (:ddkilzer)
Modified: 2020-04-21 12:28 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-20 20:30:54 PDT 
logLevelString() is declared in both LogInitialization.h and in Logging.h.

Not only that, but the same issue exists in both Source/WebCore/platform and Source/WebKit/Platform.

Also, the path and file name of Source/WebKit/Platform/foundation/LoggingFoundation.mm should use "cocoa" instead of "foundation".

See discussion starting in Bug 210724, Comment #11 to Bug 210724, Comment #14:

<https://bugs.webkit.org/show_bug.cgi?id=210724#c11>
Comment 1 Darin Adler 2020-04-21 12:28:00 PDT 
Not sure about that "Foundation" vs. "Cocoa" part. It’s OK to not make a distinction, but this logging doesn’t depend on the higher levels of Cocoa like NSView/UIView.