Bug 210706 - Always enable USE_UIKIT_KEYBOARD_ADDITIONS on iOS and Mac Catalyst
Summary: Always enable USE_UIKIT_KEYBOARD_ADDITIONS on iOS and Mac Catalyst
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-04-18 16:35 PDT by Daniel Bates
Modified: 2020-04-21 15:38 PDT (History)
0 users

See Also:

Attachments
Patch (31.69 KB, patch)
2020-04-18 16:38 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-04-18 16:35:52 PDT 
The macro USE_UIKIT_KEYBOARD_ADDITIONS was used to guard functionality pre Mac Cataylst and iOS 13. Those ships have sailed. So, always enable it and remove the macro.
Comment 1 Daniel Bates 2020-04-18 16:38:16 PDT 
Created attachment 396873 [details]
Patch
Comment 2 Daniel Bates 2020-04-18 16:41:08 PDT 
I wrote patch on top of the patch for bug #210697. Maybe that explains the conflict or maybe not being at ToT is it. I'll figure it out and rebase shortly.
Comment 3 Daniel Bates 2020-04-21 15:38:11 PDT 
Comment on attachment 396873 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396873&action=review

> Source/WebCore/dom/KeyboardEvent.cpp:115
> +#if USE(COCOA)

No such thing. Should be PLATFORM(COCOA) for this any throughout this patch.