Bug 210641 - Reduce test iterations for stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js on mips
Summary: Reduce test iterations for stress/array-buffer-view-watchpoint-can-be-fired-i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Paulo Matos
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-17 00:54 PDT by Paulo Matos
Modified: 2020-04-17 08:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.61 KB, patch)
2020-04-17 00:57 PDT, Paulo Matos 		no flags Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2020-04-17 02:00 PDT, Paulo Matos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paulo Matos 2020-04-17 00:54:41 PDT 
Reduce test iterations for mips
Comment 1 Paulo Matos 2020-04-17 00:57:49 PDT 
Created attachment 396745 [details]
Patch
Comment 2 Paulo Matos 2020-04-17 02:00:12 PDT 
Created attachment 396746 [details]
Patch
Comment 3 Caio Lima 2020-04-17 04:03:26 PDT 
Comment on attachment 396746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=396746&action=review

> JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4
> +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations;

It is possible to use `iterations = iterations === undefined ? 10000000 : iterations;`
Comment 4 Paulo Matos 2020-04-17 06:03:02 PDT 
(In reply to Caio Lima from comment #3)
> Comment on attachment 396746 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=396746&action=review
> 
> > JSTests/stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:4
> > +iterations = typeof(iterations) === 'undefined' ? 10000000 : iterations;
> 
> It is possible to use `iterations = iterations === undefined ? 10000000 :
> iterations;`

After discussing elsewhere with Caio on this, we decided to keep as is since other parts of the codebase use the `typeof(X) === 'undefined'` style.
Comment 5 Yusuke Suzuki 2020-04-17 08:40:12 PDT 
Comment on attachment 396746 [details]
Patch

r=me
Comment 6 EWS 2020-04-17 08:42:01 PDT 
Committed r260253: <https://trac.webkit.org/changeset/260253>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396746 [details].
Comment 7 Radar WebKit Bug Importer 2020-04-17 08:42:12 PDT 
<rdar://problem/61936417>